From 187dfa5344be8c4de4026bd4b994286b184a7f1c Mon Sep 17 00:00:00 2001 From: Wu Clan Date: Fri, 30 May 2025 18:56:50 +0800 Subject: [PATCH] Fix the role update business variables (#640) --- backend/app/admin/service/role_service.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/backend/app/admin/service/role_service.py b/backend/app/admin/service/role_service.py index 049e44c5..19e6d50c 100644 --- a/backend/app/admin/service/role_service.py +++ b/backend/app/admin/service/role_service.py @@ -126,8 +126,7 @@ class RoleService: if not role: raise errors.NotFoundError(msg='角色不存在') if role.name != obj.name: - role = await role_dao.get_by_name(db, obj.name) - if role: + if await role_dao.get_by_name(db, obj.name): raise errors.ForbiddenError(msg='角色已存在') count = await role_dao.update(db, pk, obj) for user in await role.awaitable_attrs.users: @@ -144,7 +143,7 @@ class RoleService: :return: """ async with async_db_session.begin() as db: - role = await role_dao.get_with_relation(db, pk) + role = await role_dao.get(db, pk) if not role: raise errors.NotFoundError(msg='角色不存在') for menu_id in menu_ids.menus: