From 39c3339a8d0cb04a75b849228187122efd498025 Mon Sep 17 00:00:00 2001
From: Wu Clan <jianhengwu0407@gmail.com>
Date: Mon, 26 May 2025 20:04:13 +0800
Subject: [PATCH] Optimize role-related data processing performance (#635)

---
 backend/app/admin/service/menu_service.py | 13 ++++++----
 backend/common/security/permission.py     | 29 ++++++++++-------------
 backend/common/security/rbac.py           | 13 ++++++----
 3 files changed, 30 insertions(+), 25 deletions(-)

diff --git a/backend/app/admin/service/menu_service.py b/backend/app/admin/service/menu_service.py
index e9ac6877..8267e2d6 100644
--- a/backend/app/admin/service/menu_service.py
+++ b/backend/app/admin/service/menu_service.py
@@ -57,11 +57,16 @@ class MenuService:
             roles = request.user.roles
             menu_tree = []
             if roles:
-                all_menus = []
+                unique_menus = {}
                 for role in roles:
-                    all_menus.extend(role.menus)
-                all_ids = [menu.id for menu in all_menus]
-                valid_menu_ids = [menu.id for menu in all_menus if menu.parent_id is None or menu.parent_id in all_ids]
+                    for menu in role.menus:
+                        unique_menus[menu.id] = menu
+                all_ids = set(unique_menus.keys())
+                valid_menu_ids = [
+                    menu_id
+                    for menu_id, menu in unique_menus.items()
+                    if menu.parent_id is None or menu.parent_id in all_ids
+                ]
                 menu_data = await menu_dao.get_sidebar(db, request.user.is_superuser, valid_menu_ids)
                 menu_tree = get_vben5_tree_data(menu_data)
             return menu_tree
diff --git a/backend/common/security/permission.py b/backend/common/security/permission.py
index 48c25946..d7a9c624 100644
--- a/backend/common/security/permission.py
+++ b/backend/common/security/permission.py
@@ -1,6 +1,5 @@
 #!/usr/bin/env python3
 # -*- coding: utf-8 -*-
-from typing import TYPE_CHECKING
 
 from fastapi import Request
 from sqlalchemy import ColumnElement, and_, or_
@@ -13,9 +12,6 @@ from backend.common.exception.errors import ServerError
 from backend.core.conf import settings
 from backend.utils.import_parse import dynamic_import_data_model
 
-if TYPE_CHECKING:
-    from backend.app.admin.model import DataRule
-
 
 class RequestPermission:
     """
@@ -60,35 +56,34 @@ async def filter_data_permission(db: AsyncSession, request: Request) -> ColumnEl
     :param request: FastAPI 请求对象
     :return:
     """
-    # 获取用户角色和数据范围
-    data_scopes = []
+    # 获取数据范围
+    unique_data_scopes = {}
     for role in request.user.roles:
         for scope in role.scopes:
             if scope.status:
-                data_scopes.append(scope)
+                unique_data_scopes[scope.id] = scope
+
+    # 转换为列表
+    data_scopes = list(unique_data_scopes.values())
 
     # 超级管理员和无规则用户不做过滤
     if request.user.is_superuser or not data_scopes:
         return or_(1 == 1)
 
     # 获取数据范围规则
-    data_rule_list: list[DataRule] = []
+    unique_data_rules = {}
     for data_scope in data_scopes:
         data_scope_with_relation = await data_scope_dao.get_with_relation(db, data_scope.id)
-        data_rule_list.extend(data_scope_with_relation.rules)
+        for rule in data_scope_with_relation.rules:
+            unique_data_rules[rule.id] = rule
 
-    # 去重
-    seen_data_rule_ids = set()
-    new_data_rule_list = []
-    for rule in data_rule_list:
-        if rule.id not in seen_data_rule_ids:
-            seen_data_rule_ids.add(rule.id)
-            new_data_rule_list.append(rule)
+    # 转换为列表
+    data_rule_list = list(unique_data_rules.values())
 
     where_and_list = []
     where_or_list = []
 
-    for data_rule in new_data_rule_list:
+    for data_rule in data_rule_list:
         # 验证规则模型
         rule_model = data_rule.model
         if rule_model not in settings.DATA_PERMISSION_MODELS:
diff --git a/backend/common/security/rbac.py b/backend/common/security/rbac.py
index 51b728fb..8024e0de 100644
--- a/backend/common/security/rbac.py
+++ b/backend/common/security/rbac.py
@@ -60,12 +60,17 @@ async def rbac_verify(request: Request, _token: str = DependsJwtAuth) -> None:
         if path_auth_perm in settings.RBAC_ROLE_MENU_EXCLUDE:
             return
 
-        # 已分配菜单权限校验
-        allow_perms = []
+        # 菜单去重
+        unique_menus = {}
         for role in user_roles:
             for menu in role.menus:
-                if menu.perms and menu.status == StatusType.enable:
-                    allow_perms.extend(menu.perms.split(','))
+                unique_menus[menu.id] = menu
+
+        # 已分配菜单权限校验
+        allow_perms = []
+        for menu in list(unique_menus.values()):
+            if menu.perms and menu.status == StatusType.enable:
+                allow_perms.extend(menu.perms.split(','))
         if path_auth_perm not in allow_perms:
             raise AuthorizationError
     else: