From 4aa0068d2d7b40307e6e38a4c2db5407f2b11d77 Mon Sep 17 00:00:00 2001 From: wenjianzhang Date: Thu, 5 Sep 2024 18:29:50 +0800 Subject: [PATCH] =?UTF-8?q?perf=F0=9F=91=8C:=20update=20SysDept=20Get=20Fi?= =?UTF-8?q?rst=20to=20FirstOrInit?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- app/admin/service/sys_dept.go | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/app/admin/service/sys_dept.go b/app/admin/service/sys_dept.go index cffd730a..a82675ae 100644 --- a/app/admin/service/sys_dept.go +++ b/app/admin/service/sys_dept.go @@ -7,8 +7,6 @@ import ( log "github.com/go-admin-team/go-admin-core/logger" "github.com/go-admin-team/go-admin-core/sdk/pkg" - "gorm.io/gorm" - "go-admin/app/admin/service/dto" cDto "go-admin/common/dto" @@ -41,16 +39,18 @@ func (e *SysDept) Get(d *dto.SysDeptGetReq, model *models.SysDept) error { var err error var data models.SysDept - db := e.Orm.Model(&data). - First(model, d.GetId()) - err = db.Error - if err != nil && errors.Is(err, gorm.ErrRecordNotFound) { - err = errors.New("查看对象不存在或无权查看") + err = e.Orm.Model(&data). + FirstOrInit(model, d.GetId()). + Error + if err != nil { e.Log.Errorf("db error:%s", err) + _ = e.AddError(err) return err } - if err = db.Error; err != nil { - e.Log.Errorf("db error:%s", err) + if model.DeptId == 0 { + err = errors.New("查看对象不存在或无权查看") + e.Log.Errorf("Service GetSysApi error: %s", err) + _ = e.AddError(err) return err } return nil