From e70a0b131416962210b337a8bf8201366e3e49dc Mon Sep 17 00:00:00 2001 From: wenjianzhang Date: Wed, 4 Sep 2024 20:22:49 +0800 Subject: [PATCH] =?UTF-8?q?perf=F0=9F=91=8C:=20update=20SysConfig=20Get=20?= =?UTF-8?q?First=20to=20FirstOrInit?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- app/admin/service/sys_config.go | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/app/admin/service/sys_config.go b/app/admin/service/sys_config.go index d50ed218..ed3c6949 100644 --- a/app/admin/service/sys_config.go +++ b/app/admin/service/sys_config.go @@ -8,7 +8,6 @@ import ( cDto "go-admin/common/dto" "github.com/go-admin-team/go-admin-core/sdk/service" - "gorm.io/gorm" ) type SysConfig struct { @@ -33,14 +32,16 @@ func (e *SysConfig) GetPage(c *dto.SysConfigGetPageReq, list *[]models.SysConfig // Get 获取SysConfig对象 func (e *SysConfig) Get(d *dto.SysConfigGetReq, model *models.SysConfig) error { - err := e.Orm.First(model, d.GetId()).Error - if err != nil && errors.Is(err, gorm.ErrRecordNotFound) { - err = errors.New("查看对象不存在或无权查看") - e.Log.Errorf("Service GetSysConfigPage error:%s", err) + err := e.Orm.FirstOrInit(model, d.GetId()).Error + if err != nil { + e.Log.Errorf("db error:%s", err) + _ = e.AddError(err) return err } - if err != nil { - e.Log.Errorf("Service GetSysConfig error:%s", err) + if model.Id == 0 { + err = errors.New("查看对象不存在或无权查看") + e.Log.Errorf("Service GetSysApi error: %s", err) + _ = e.AddError(err) return err } return nil