From f30889bd19482b97e007f0c0f36d4ed366f86ea3 Mon Sep 17 00:00:00 2001 From: wenjianzhang Date: Tue, 3 Sep 2024 21:22:09 +0800 Subject: [PATCH] =?UTF-8?q?perf=F0=9F=91=8C:=20update=20SysApi=20Get=20Fun?= =?UTF-8?q?c=20First=20to=20FirstOrInit?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- app/admin/service/sys_api.go | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/app/admin/service/sys_api.go b/app/admin/service/sys_api.go index cb4d895b..b098022f 100644 --- a/app/admin/service/sys_api.go +++ b/app/admin/service/sys_api.go @@ -6,8 +6,6 @@ import ( "github.com/go-admin-team/go-admin-core/sdk/runtime" "github.com/go-admin-team/go-admin-core/sdk/service" - "gorm.io/gorm" - "go-admin/app/admin/models" "go-admin/app/admin/service/dto" "go-admin/common/actions" @@ -58,15 +56,15 @@ func (e *SysApi) Get(d *dto.SysApiGetReq, p *actions.DataPermission, model *mode Scopes( actions.Permission(data.TableName(), p), ). - First(model, d.GetId()).Error - if err != nil && errors.Is(err, gorm.ErrRecordNotFound) { - err = errors.New("查看对象不存在或无权查看") - e.Log.Errorf("Service GetSysApi error:%s", err) + FirstOrInit(model, d.GetId()).Error + if err != nil { + e.Log.Errorf("db error:%s", err) _ = e.AddError(err) return e } - if err != nil { - e.Log.Errorf("db error:%s", err) + if model.Id == 0 { + err = errors.New("查看对象不存在或无权查看") + e.Log.Errorf("Service GetSysApi error: %s", err) _ = e.AddError(err) return e }