mirror of
https://github.com/go-admin-team/go-admin.git
synced 2026-09-22 02:27:57 +00:00
The repository has 19 test files and nothing was running any of them. Both workflows build with go build, which does not compile _test.go, the Makefile's test target was commented out, and there is no pre-commit hook. Every test in the tree, including the schema guards that exist precisely to catch a silent breakage, only ran when someone remembered to type go test. Enables the commented-out target and calls it from go.yml, the one workflow that fires on every push and pull request. build.yml is left alone: it skips documentation-only changes and deploys on master, so it is the wrong place for a gate that should never be skipped. Runs with -race. common/actions reuses model instances across concurrent requests, so a Generate() that returns in place rather than a copy leaks data between them, which a single-threaded run cannot see. Verified locally: the suite passes under CGO_ENABLED=0 and under -race, and make test exits non-zero when a test fails, so the step actually gates. Claude-Session: https://claude.ai/code/session_01DJhM6LvhkNPej35wy9F7Aq