mirror of
https://github.com/go-admin-team/go-admin.git
synced 2026-09-30 12:51:25 +00:00
zhangwenjian
ea2d807071
WithContextDb and the five CRUD actions passed the *gin.Context itself to GORM as the query's context. database/sql watches the context of a query that returns rows inside a transaction from a goroutine of its own, which can still read it after the handler returns - and gin hands that Context to the next request as soon as the handler returns. GORM wraps every write in a transaction, and an INSERT on SQLite or PostgreSQL returns the new key as a row, so any write raced with the next request's reset. The race detector reports it on the second of two sequential requests. They now pass c.Request.Context(), which belongs to one request only and is cancelled when its client goes away.
61 lines
1.8 KiB
Go
61 lines
1.8 KiB
Go
package middleware
|
|
|
|
import (
|
|
"net/http"
|
|
"net/http/httptest"
|
|
"testing"
|
|
|
|
"github.com/gin-gonic/gin"
|
|
"github.com/glebarez/sqlite"
|
|
"github.com/go-admin-team/go-admin-core/v2/sdk"
|
|
"gorm.io/gorm"
|
|
)
|
|
|
|
// database/sql watches the context of a query that returns rows inside a
|
|
// transaction from a goroutine of its own, which can still be reading it
|
|
// after the handler has returned. GORM wraps every write in a transaction,
|
|
// and an INSERT on SQLite or PostgreSQL returns the new key as a row. gin
|
|
// reuses its Context for the next request as soon as the handler returns, so
|
|
// a query given the gin.Context races with that reuse; given the request's
|
|
// own context, it does not. Sequential requests are enough for the reuse,
|
|
// and -race, which make test runs with, reports it.
|
|
type probeRow struct {
|
|
Id int `gorm:"primaryKey;autoIncrement"`
|
|
}
|
|
|
|
func (probeRow) TableName() string { return "with_context_db_probe" }
|
|
|
|
func TestWithContextDbDoesNotHandQueriesThePooledContext(t *testing.T) {
|
|
const host = "with-context-db.test"
|
|
db, err := gorm.Open(sqlite.Open("file:"+t.Name()+"?mode=memory&cache=shared"), &gorm.Config{})
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if err := db.AutoMigrate(&probeRow{}); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
previous := sdk.Runtime.GetDbByTenant(host)
|
|
sdk.Runtime.SetDbByTenant(host, db)
|
|
t.Cleanup(func() { sdk.Runtime.SetDbByTenant(host, previous) })
|
|
|
|
gin.SetMode(gin.TestMode)
|
|
r := gin.New()
|
|
r.Use(WithContextDb)
|
|
r.GET("/", func(c *gin.Context) {
|
|
if err := c.MustGet("db").(*gorm.DB).Create(&probeRow{}).Error; err != nil {
|
|
c.Status(http.StatusInternalServerError)
|
|
return
|
|
}
|
|
c.Status(http.StatusOK)
|
|
})
|
|
for i := 0; i < 20; i++ {
|
|
w := httptest.NewRecorder()
|
|
req := httptest.NewRequest(http.MethodGet, "/", nil)
|
|
req.Host = host
|
|
r.ServeHTTP(w, req)
|
|
if w.Code != http.StatusOK {
|
|
t.Fatalf("request %d answered %d", i, w.Code)
|
|
}
|
|
}
|
|
}
|